On a visit to Georgian Edinburgh, Alice Roberts explores the city's finest architecture, 'Auld Reekie', the roots of modern Scottishness, and some dark imperial controversies